-
Notifications
You must be signed in to change notification settings - Fork 9
manual build option, npm i, and remove #each keys #24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
manual build
disable cache
|
I currently still see the issue of not being able to follow the about-us link. Dockerfile run the container go to There should be a file called The issue does not have to do with the type of static file server because both the python and the npx static file server give a 404 |
|
Also it has been really hard to figure out how to run the tests locally, I still have not yet. Can you add a github action that runs the tests so we dont have to rely on our own machine? |
|
Just tried again, and I am not getting the about-us not loading issue, but me and Ted seem to have found another issue |
|
Run a static file server on port 5173 Then in a different terminal run the tests The donate test fails. You can verify this by going to the donate page directly |
I'd like to address this post launch, and I've created an issue for it: #27 |
This should now be fixed |
|
NPM audit appears to produce 1 low and 2 high risk vulnerabilities but these do not appear to be easilly exploitable if we are just generating a static website |
tedm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tedm approves
I cannot reproduce this anymore! |
|
I dont think it is secure to be able to run the CI whenever we want because if someone puts a piece of maleware in the next version of an NPM package and we did not audit it before we ran the CI again, we will be pushing security issues. If it is run at merge time, I would have ran |
|
@kevinkace @abacef Kevin, Mark - let's discuss at the meeting. Kaylee and I are on now, Kevin is eating but will be here at 6:30p if not earlier. |
I updated the GH action (
./.github/workflows/static.yml) to allow manually kicking off a build, and disabled automatic builds with pushes to main.npm cifor some reason wouldn't update thepackage-lock.jsonand kept complaining that it was out of sync even after runningnpm ilocally to update the lock file. The action completed successfully after changing tonpm i.https://github.com/kevinkace/Local-Connectivity-Lab.github.io/actions/runs/20872694540
This should be changed back to
npm ciafter the build completes successfully.Lastly, I removed specifying
#eachkeys, and updated./estlint.config.jsto suit. Keys are only required if items are added/removed from an#each, which currently we're not doing.