Skip to content

Conversation

@kevinkace
Copy link
Collaborator

@kevinkace kevinkace commented Jan 10, 2026

I updated the GH action (./.github/workflows/static.yml) to allow manually kicking off a build, and disabled automatic builds with pushes to main.

npm ci for some reason wouldn't update the package-lock.json and kept complaining that it was out of sync even after running npm i locally to update the lock file. The action completed successfully after changing to npm i.
https://github.com/kevinkace/Local-Connectivity-Lab.github.io/actions/runs/20872694540
This should be changed back to npm ci after the build completes successfully.

Lastly, I removed specifying #each keys, and updated ./estlint.config.js to suit. Keys are only required if items are added/removed from an #each, which currently we're not doing.

@kevinkace kevinkace changed the title manual build option, and npm i manual build option, npm i, and remove #each keys Jan 13, 2026
@abacef
Copy link
Collaborator

abacef commented Jan 14, 2026

I currently still see the issue of not being able to follow the about-us link.

Dockerfile

from node:22.17.0

cmd ["bash", "-lc", "cd /code && npm install && npm run build && cd build && npx http-server -p 8001"]

run the container

docker run -v ./Local-Connectivity-Lab.github.io:/code -p 8001:8001

go to localhost:8001/about-us
it does not load.

There should be a file called about-us flat in the /build directory I assume?

The issue does not have to do with the type of static file server because both the python and the npx static file server give a 404

npx http-server -p 8001
python3 -m http.server 8001

@abacef
Copy link
Collaborator

abacef commented Jan 14, 2026

Also it has been really hard to figure out how to run the tests locally, I still have not yet. Can you add a github action that runs the tests so we dont have to rely on our own machine?

@abacef
Copy link
Collaborator

abacef commented Jan 14, 2026

Just tried again, and I am not getting the about-us not loading issue, but me and Ted seem to have found another issue

@abacef
Copy link
Collaborator

abacef commented Jan 14, 2026

Run a static file server on port 5173

npx http-server -p 5173

Then in a different terminal run the tests

npm run test

The donate test fails.

You can verify this by going to the donate page directly http://localhost:5173/donate it will try to redirect forever

@kevinkace
Copy link
Collaborator Author

Also it has been really hard to figure out how to run the tests locally, I still have not yet. Can you add a github action that runs the tests so we dont have to rely on our own machine?

I'd like to address this post launch, and I've created an issue for it: #27

@kevinkace
Copy link
Collaborator Author

Run a static file server on port 5173

npx http-server -p 5173

Then in a different terminal run the tests

npm run test

The donate test fails.

You can verify this by going to the donate page directly http://localhost:5173/donate it will try to redirect forever

This should now be fixed

@kevinkace kevinkace mentioned this pull request Jan 16, 2026
@abacef
Copy link
Collaborator

abacef commented Jan 17, 2026

NPM audit appears to produce 1 low and 2 high risk vulnerabilities but these do not appear to be easilly exploitable if we are just generating a static website

Copy link
Contributor

@tedm tedm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tedm approves

@abacef
Copy link
Collaborator

abacef commented Jan 17, 2026

Run a static file server on port 5173

npx http-server -p 5173

Then in a different terminal run the tests

npm run test

The donate test fails.
You can verify this by going to the donate page directly http://localhost:5173/donate it will try to redirect forever

This should now be fixed

I cannot reproduce this anymore!

@tedm tedm merged commit 57bacae into Local-Connectivity-Lab:main Jan 17, 2026
@abacef
Copy link
Collaborator

abacef commented Jan 17, 2026

I dont think it is secure to be able to run the CI whenever we want because if someone puts a piece of maleware in the next version of an NPM package and we did not audit it before we ran the CI again, we will be pushing security issues. If it is run at merge time, I would have ran npm audit or something before I approved. I do not approve of this change.

@tedm
Copy link
Contributor

tedm commented Jan 17, 2026

@kevinkace @abacef Kevin, Mark - let's discuss at the meeting. Kaylee and I are on now, Kevin is eating but will be here at 6:30p if not earlier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants